Make indirect drawing opt-out instead of opt-in, enabling multidraw by default. #16757
+109
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default. This patch replaces the undocumented `NoGpuCulling` component with a new component, `NoIndirectDrawing`, effectively turning indirect drawing on by default. Indirect mode is needed for the recently-landed multidraw feature (bevyengine#16427). Since multidraw is such a win for performance, when that feature is supported the small performance tax that indirect mode incurs is virtually always worth paying. To ensure that custom drawing code such as that in the `custom_shader_instancing` example continues to function, this commit additionally makes GPU culling take the `NoFrustumCulling` component into account. This PR is an alternative to bevyengine#16670 that doesn't break the `custom_shader_instancing` example. **PR bevyengine#16755 should land first in order to avoid breaking deferred rendering, as multidraw currently breaks it**.
pcwalton
added
C-Bug
alice-i-cecile
added
the
S-Blocked
|
Did you mean to add the new component to custom_shader_instancing? |
|
@JMS55 Good catch, fixed. |
bushrat011899
approved these changes
Dec 12, 2024
pcwalton
removed
S-Blocked
|
Looks like the tests all passed except for some timeouts on Android that look like test flakiness rather than actual failures. |
alice-i-cecile
approved these changes
Dec 13, 2024
alice-i-cecile
removed
the
S-Needs-Review
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces the undocumented
NoGpuCullingcomponent with a new component,NoIndirectDrawing, effectively turning indirect drawing on by default. Indirect mode is needed for the recently-landed multidraw feature (#16427). Since multidraw is such a win for performance, when that feature is supported the small performance tax that indirect mode incurs is virtually always worth paying.To ensure that custom drawing code such as that in the
custom_shader_instancingexample continues to function, this commit additionally makes GPU culling take theNoFrustumCullingcomponent into account.This PR is an alternative to #16670 that doesn't break the
custom_shader_instancingexample. PR #16755 should land first in order to avoid breaking deferred rendering, as multidraw currently breaks it.Migration Guide
GpuCullingcomponent is no longer available. To disable indirect mode, which may be useful with custom render nodes, add the newNoIndirectDrawingcomponent to your camera.